MDEV-39169: Replace deprecated network functions with modern POSIX equivalents#4856
Merged
Conversation
gkodinov
added
the
External Contribution
gkodinov
changed the title
gkodinov
approved these changes
Mar 25, 2026
gkodinov
left a comment
gkodinov
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review.
LGTM. I've taken the liberty of filing a jira for the task.
Please stand by for the final review.
I'd also be nice to have some sort of testing for this. Maybe resolve some IPv6 IP or something?
FaramosCZ
force-pushed
the
resolveip_ipv6
branch
2 times, most recently
from
March 25, 2026 13:02
70e52fc to
6333f1a
Compare
raghunandanbhat
left a comment
raghunandanbhat
left a comment
Contributor
There was a problem hiding this comment.
@FaramosCZ , thanks for the contribution.
I have a few suggestion-
- please squash two commits into a single commit
- ensure that commit message starts with the MDEV number, something like
MDEV-39169:... - plus, issues I found in test (comments below).
FaramosCZ
marked this pull request as draft
March 27, 2026 15:03
FaramosCZ
force-pushed
the
resolveip_ipv6
branch
4 times, most recently
from
March 28, 2026 08:58
e64c305 to
dbd5f00
Compare
FaramosCZ
marked this pull request as ready for review
March 29, 2026 08:51
Contributor
Author
|
I fixed all concerns you listed. |
raghunandanbhat
requested changes
Mar 30, 2026
Contributor
There was a problem hiding this comment.
@FaramosCZ, looks good overall.
cases like ::, ::1, IPv4-mapped IPv6 addresses, etc seem to work fine. however, some test cases are "sneaky". please fix them.
FaramosCZ
marked this pull request as draft
March 30, 2026 10:21
FaramosCZ
force-pushed
the
resolveip_ipv6
branch
5 times, most recently
from
March 30, 2026 14:00
b1399e9 to
af57ebc
Compare
FaramosCZ
marked this pull request as ready for review
March 30, 2026 16:02
raghunandanbhat
previously approved these changes
Mar 31, 2026
raghunandanbhat
left a comment
raghunandanbhat
left a comment
Contributor
There was a problem hiding this comment.
looks good to me. thank you @FaramosCZ for the contribution.
@gkodinov, I believe this needs go through QA/testing before we merge this.
raghunandanbhat
dismissed
their stale review
March 31, 2026 06:06
test failure found in build bot - amd64-ubuntu-2204 & s390x-ubuntu-2204-debug
elenst
requested review from
mariadb-RameshSivaraman
and removed request for
elenst
June 11, 2026 14:34
gkodinov
enabled auto-merge (rebase)
July 15, 2026 07:47
gkodinov
disabled auto-merge
July 15, 2026 07:47
gkodinov
enabled auto-merge (rebase)
July 15, 2026 07:49
auto-merge was automatically disabled
July 15, 2026 12:10
Rebase failed
gkodinov
enabled auto-merge (rebase)
July 15, 2026 12:41
Replace inet_aton/inet_addr/gethostbyname/gethostbyaddr with their modern POSIX equivalents inet_pton/getaddrinfo/getnameinfo. This adds IPv6 support to resolveip and removes dependency on the deprecated h_errno global. Handle IPv6 unspecified address (::) as Null-IP-Addr, consistent with existing IPv4 INADDR_ANY handling for 0.0.0.0. Add MTR test covering IPv4/IPv6 reverse lookups, special addresses, multiple arguments, mixed address types, and invalid hostname handling. Co-Authored-By: Claude AI <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveip: replace inet_aton/inet_addr, gethostbyname, gethostbyaddr, inet_ntoa with inet_pton, getaddrinfo, getnameinfo, inet_ntop.
These deprecated functions are IPv4-only and some are not thread-safe (gethostbyname, gethostbyaddr, and inet_ntoa use static internal buffers). The modernized code:
Bump version from 2.3 to 2.4 to reflect the API change.
Update Solaris library search in CMakeLists.txt from inet_aton to getaddrinfo since the old function is no longer referenced.